[fix] h2 double complete#558
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #558 +/- ##
=======================================
Coverage 79.68% 79.68%
=======================================
Files 28 28
Lines 12082 12085 +3
=======================================
+ Hits 9627 9630 +3
Misses 2455 2455 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
azkrishpy
reviewed
May 8, 2026
| } | ||
|
|
||
| /* Test that cancelling a stream after GOAWAY does not crash from double stream completion. | ||
| * Reproduces P428540711: cancel() schedules cross-thread task, but s_finish_shutdown already |
Contributor
There was a problem hiding this comment.
should we mention this magic number?
Contributor
Author
There was a problem hiding this comment.
it's a comment in the test, so pretty much for ourselves to reference.
azkrishpy
approved these changes
May 8, 2026
DmitriyMusatkin
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Arguably, we can prevent the RST_STREAM from a various places (User invoke, running the cross thread task ,etc..) But, sending it is not the real problem, and we do protect a lot around those when the connection/stream is shutting down. So, I chose to prevent the complete to happen again, so, every place can safely try to complete the stream regardless if it's already completed or not.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.